search

harleyjones / Quacker

The continuation of fritter with feeds
MIT License
190 stars 2 forks source link

[BUG] Black theme isn't actually black #27

Open nvllz opened 4 months ago

nvllz commented 4 months ago

Describe the bug There is a black theme option, but most of the time there are some random tones and other (useless) coloring what just defeats the purpose of using pure black theme, the one you would expect to benefit from AMOLED displays.

Expected behavior I think it is expected that the app respects "true black" and "true black for tweet cards" settings. The latter is not even a thing, as shown below, where you can see that the card is not really black.

Screenshots 947e12ed-fae2-4fa7-a406-c8a4f8ecba41

Smartphone (please complete the following information):

harleyjones commented 4 months ago

I cannot reproduce this issue, could you take a screenshot of your Theme settings

nvllz commented 4 months ago

How does it look like on your side?

2ac92eb6-17c6-435d-85f4-1708d9c6e6a5

harleyjones commented 4 months ago

I am using the same settings on v3.4.3 and tweet cards are true black

Screenshot_2024-05-04-10-27-44-597_com.thehcj.quacker.jpg

nvllz commented 4 months ago

As you can see below, it's still using some dark accent color. The "Pure Black" setting is expected to turn the tweet cards background black instead (hex #000000).

https://github.com/TheHCJ/Quacker/assets/110673332/ae26e085-49ef-4531-9db1-1ed58c247cb1

harleyjones commented 4 months ago

Oh thanks, I may of not noticed it. I'll see if it's todo with color harmonisation.

harleyjones commented 4 months ago

I think I found the root cause of this, I'll be fixing this in the next release