Update to use aws-sdk-go-v2

harlow / kinesis-consumer

Golang library for consuming Kinesis stream data

MIT License

264 stars 90 forks source link

Update to use aws-sdk-go-v2 #141

Closed harlow closed 3 years ago

harlow commented 3 years ago

This is sweeping update of the client library to use the V2 Golang implementation of AWS SDK

Fixes: #138

[x] Upgrade library to AWS SDK V2
[x] Go forward plan for de-aggregation (not included in v2 sdk)
[ ] Go forward plan for mocking/stubbing (v2 sdk has removed the iface)
[x] Run end-to-end tests against local kinesis
[ ] Run end-to-end tests against production kinesis

Blocked on: https://github.com/awslabs/kinesis-aggregation/pull/143

harlow commented 3 years ago

@akrantz01 any chance you can pull this branch into yours and see if everything lines up OK? All the tests I've run locally are going well; after I get the de-aggregation sorted I think its really close

akrantz01 commented 3 years ago

It's hard to say whether everything lines up correctly. Telegraf was on v0.3.1 before updating, and by the looks of it, a handful of things changed between v0.3.1 and v0.3.5.

Aside from updating between v0.3.1 and v0.3.5, all the tests pass without modifying any core components. So it seems like everything lines up correctly, but I could be wrong. I've also yet to test actually connecting to AWS Kinesis.