search

harlow / kinesis-consumer

Golang library for consuming Kinesis stream data
MIT License
264 stars 90 forks source link

fix nil pointer dereference on AWS errors #148

Closed jwhitaker-swiftnav closed 4 months ago

jwhitaker-swiftnav commented 1 year ago

Hey, currently certain AWS errors cause a segfault instead of returning the err :(

For example, if your stream gets recreated outside of your app, your stored sharditerator is no longer valid and you'll get an AWS error when you try to use it.

EDIT: I've also changed listShards error handling - because we no longer panic, the "loop forever even if you error" behaviour of listShards is now quite problematic. I think it should return error - if client wants to loop and try again forever they are free to do so.

harlow commented 4 months ago

Makes sense, thanks for PR!