harlow / kinesis-consumer

Golang library for consuming Kinesis stream data
MIT License
264 stars 90 forks source link

Retryable errors don't get retried in master #152

Closed jtackaberry closed 4 weeks ago

jtackaberry commented 1 year ago

isRetriableError() is broken in master which causes retryable errors to abort. Basically this function needs to look something like:

func isRetriableError(err error) bool {
    var apiErr smithy.APIError
    if !errors.As(err, &apiErr) {
        return false
    }
    switch apiErr.(type) {
    case *types.ExpiredIteratorException:
        return true
    case *types.ProvisionedThroughputExceededException:
        return true
    default:
        return false
    }
}

I can submit a PR but it's not entirely clear whether this project is dead or not, so I'll wait for signs of life before investing the effort. :)

mskonovalov commented 4 weeks ago

I guess this is fixed now in https://github.com/harlow/kinesis-consumer/pull/159