harlowja / fasteners

A python package that provides useful locks.
Apache License 2.0
246 stars 45 forks source link

Process Lock tests assume POSIX #22

Closed johntyree closed 8 years ago

johntyree commented 8 years ago

The test_process_lock module assumes we're on a POSIX system.

It looks like it can be fixed pretty easily, but I really don't know much about the details of locking on various platforms.

Here we import fcntl: https://github.com/harlowja/fasteners/blob/master/fasteners/tests/test_process_lock.py#L19

And here we use it: https://github.com/harlowja/fasteners/blob/master/fasteners/tests/test_process_lock.py#L127

And here it looks like we could be using this instead: https://github.com/harlowja/fasteners/blob/master/fasteners/process_lock.py#L227