search

harlowja / fasteners

A python package that provides useful locks.
Apache License 2.0
246 stars 45 forks source link

Release new version #61

Closed manoprenko closed 3 years ago

manoprenko commented 3 years ago

Hi!

It would be great to make a new release (particularly I'm interested in this commit) and to have it available on pypi. Could you help with this?

psarka commented 3 years ago

@harlowja I think this is a good point to make a release.

It has accumulated a couple of features and fixes, and would be the last for python 2.7, what do you think?

I can make the update to the changelog, is there anything else I can do to help you with this?

harlowja commented 3 years ago

Sounds good to me, let's do it. I can try to get that done after you update the changelog; shouldn't be hard :-P

psarka commented 3 years ago

Voila: https://github.com/harlowja/fasteners/pull/62

psarka commented 3 years ago

@harlowja Check out the github actions, there is a default one for publishing to pypi, maybe you will find it worthwhile to setup :) https://github.com/harlowja/fasteners/actions/new

harlowja commented 3 years ago

Probably a good idea, since I don't have tons of time to do all this stuff, lol

psarka commented 3 years ago

I added the required action to master, all it remains is for you to go to repo ⚙Settings → Secrets and add two env variables:

PYPI_USERNAME PYPI_PASSWORD

with your corresponding credentials. When that's done, create a new release v0.16 on github, and it will be uploaded to PyPi automatically.

harlowja commented 3 years ago

How about I add you as co-maintainer on pypi :-P

harlowja commented 3 years ago

What's your PYPI username? @psarka

psarka commented 3 years ago

That would work as well, my PYPI username is the same - psarka.

But in this case you will need to give me admin rights to this repository, as I can't access the settings at the moment.

harlowja commented 3 years ago

Ok, u got invited on pypi, but doesn't seem that github has a way to give you admin rights to this repository from what I can tell, may just have to upload to pypi via other methods for now.

harlowja commented 3 years ago

I'll see about doing that settings setup at some point in the future, I guess for now just upload manually with twine upload

https://twine.readthedocs.io/en/latest/#twine-upload

psarka commented 3 years ago

Done!

https://pypi.org/project/fasteners/0.16/

harlowja commented 3 years ago

Awesome, nice.

manoprenko commented 3 years ago

Thanks a lot guys!