harlowja / fasteners

A python package that provides useful locks.
Apache License 2.0
243 stars 45 forks source link

Cleanup, tests and docs for Exceptions and Errors #82

Open psarka opened 2 years ago

psarka commented 2 years ago

The issue #72 was caused by 0.16.1 raising different exception than 0.16 - TypeError instead of threading.ThreadError. The former does not inherit from Exception, so duplicity failed to intercept it when releasing the lock twice (they always release the lock twice).

We need tests to make sure we maintain the exception interface, as well as docs. And ideally we should not be raising threading.ThreadError, as processes have nothing to do with that.