search

harm-less / angular-sticky

Pure javascript AngularJS directive to make elements stick when scrolling
http://harm-less.github.io/angular-sticky
83 stars 38 forks source link

Remove jQuery selectors and methods #5

Closed valexiev closed 7 years ago

valexiev commented 8 years ago

Make it with standard JavaScript and Angular so there is no need for jQuery.

harm-less commented 8 years ago

Thanks for your pull request. It was on my to-do list to see if I could only make it only depend on jqLite. I'll merge this pull tomorrow as well.

harm-less commented 8 years ago

Btw, in the karma config file a reference to jQuery is still there. Can you create another commit with this reference removed to see if the plugin would still pass in Travis CI?

harm-less commented 8 years ago

Hey, I ran the pull through Karma with jQuery removed from karma.conf.js, but this breaks it as I was afraid of. I think this needs to be fixed if this pull-request will make any sense, what about you?

In branch pr/5 you'll be able to see this.

harm-less commented 8 years ago

I'm not entirely sure what you meant with your line comment. But I don't think Karma is necessarily dependent on jQuery. It's just that the current state of the code (even with your changes), without jQuery it doesn't pass. But if those errors can be fixed, the resulting build will be an Angular Sticky that will work without jQuery.

codeuniquely commented 7 years ago

Can this branch be integrated please - ???