search

harmony-dev / beacon-chain-java

Java implementation of Ethereum 2.0 Beacon Chain
Apache License 2.0
34 stars 9 forks source link

Discovery v5 #189

Closed zilm13 closed 5 years ago

zilm13 commented 5 years ago

Implementation of this: https://github.com/ethereum/devp2p/blob/master/discv5/discv5.md

Still in work, need to finish some things, add network, plus refactoring especially around messageHandler <-> Context, the system is raw.

zilm13 commented 5 years ago

Network using Netty added.

TODO:

zilm13 commented 5 years ago

TODO: Buckets according to spec TODO: handshake crypto

zilm13 commented 5 years ago
zilm13 commented 5 years ago

@mkalinin ready for review Current TODO:

zilm13 commented 5 years ago

@mkalinin Finished it. Please, review.

shahankhatch commented 5 years ago

lgtm. I have a minor request to review/accept #210 which renames two methods.

zilm13 commented 5 years ago

@mkalinin I don't like discv5 as a lot of code could be reused in, say, discv6

shahankhatch commented 5 years ago

@mkalinin I don't like discv5 as a lot of code could be reused in, say, discv6

I agree with this reasoning.

mkalinin commented 5 years ago

This particular implementation is discv5. I don't think it's gonna be re-used for discvX in the future. Anyway, it doesn't matter much :)