This refactor is to make it clearer when magic is applied to the first parameter in WhoAreYouPacket. For both create methods, I thought the Bytes and Bytes32 types of the first parameter were too closely related, making it hard for me to distinguish when generalizing types (integration of this discv5 into Artemis uses Tuweni Bytes).
zilm13
commented
4 years ago
This refactor is to make it clearer when magic is applied to the first parameter in
WhoAreYouPacket. For bothcreatemethods, I thought theBytesandBytes32types of the first parameter were too closely related, making it hard for me to distinguish when generalizing types (integration of this discv5 into Artemis uses TuweniBytes).