search

harmony-development / protocol

The schemas for the Harmony protocol
Apache License 2.0
21 stars 2 forks source link

feat(chat): add guild kinds, add direct message and room guilds #67

Closed yusdacra closed 3 years ago

bluskript commented 3 years ago

// - If the invite used is in a user's "pending invites" list, it should be // removed from there.

There is no need for a state other than accept. Invites being declined should always be silent.

pontaoski commented 3 years ago

the protocol shouldn't be strongly opinionated; there are three ways to deal with any invitation anywhere:

these have different ramifications/social implications that users may want, so we should support all three

pontaoski commented 3 years ago

can we get some more message types to be sent by system?

yusdacra commented 3 years ago

can we get some more message types to be sent by system?

  • dm accepted message
  • dm rejected message
  • room upgraded to guild message

"dm accepted message" is just "user joined" event. "dm rejected message" is already included as DMInviteRejected event. Why do we need a "room upgraded to guild" event? It would be easy to have it but I can't think of any use cases.

pontaoski commented 3 years ago

can we get some more message types to be sent by system?

  • dm accepted message
  • dm rejected message
  • room upgraded to guild message

"dm accepted message" is just "user joined" event. "dm rejected message" is already included as DMInviteRejected event. Why do we need a "room upgraded to guild" event? It would be easy to have it but I can't think of any use cases.

i'm talking about message types, not stream event stuff, so that clients could display something like

janet: hi
yusuf: hi
[ janet upgraded :trollface: to a guild ]
yusuf: wow
janet: hm, i wonder if they're coming
[ yusuf rejected the invite ]
janet: i guess not
[ blusk invited yusuf to the group ]
[ yusuf accepted the invite ]
[ yusuf joined the group ]
yusuf: hentai
yusdacra commented 3 years ago

can we get some more message types to be sent by system?

  • dm accepted message
  • dm rejected message
  • room upgraded to guild message

"dm accepted message" is just "user joined" event. "dm rejected message" is already included as DMInviteRejected event. Why do we need a "room upgraded to guild" event? It would be easy to have it but I can't think of any use cases.

i'm talking about message types, not stream event stuff, so that clients could display something like

janet: hi
yusuf: hi
[ janet upgraded :trollface: to a guild ]
yusuf: wow
janet: hm, i wonder if they're coming
[ yusuf rejected the invite ]
janet: i guess not
[ blusk invited yusuf to the group ]
[ yusuf accepted the invite ]
[ yusuf joined the group ]
yusuf: hentai

Check out c2217cbbc92d91424a98794fd47c13e3c9da43e4

pontaoski commented 3 years ago

pls no nested oneofs, just do a flat hierarchy