harmony-one / bounties

Bounty program is to help the community take part in the development of the Harmony blockchain. It covers from core feature to validator tooling, from dApp development to DeFi integration.

MIT License

59 stars 23 forks source link

[Ledger] Fix edit validator bug for removing bls key #22

Open gupadhyaya opened 3 years ago

gupadhyaya commented 3 years ago

Description

Currently, there is a bug in the ledger firmware (https://github.com/harmony-one/ledger-app-one) that prevents validators from signing an edit validator transaction that tries to remove the bls key. All other edit validator options work correctly, only the remove-bls-key option fails with following error: Couldn't sign staking transaction, error: Error code 0x6802. This error may be due to invalid input bytes length sent to the ledger.

Context

Edit validator documentation: https://docs.harmony.one/home/network/validators/managing-a-validator/changing-validator-information
The error can also be reproduced using go-sdk (https://github.com/harmony-one/go-sdk), where you will use ./hmy -e for ledger
The error is reproducible for both nano s/x
The ledger nano s cost will be reimbursed

Acceptance Criteria

[ ] Fix the bug and make a PR to https://github.com/harmony-one/ledger-app-one repo

Reward

$1000 equivalent in ONE tokens

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 6864.9452 ONE (998.47 USD @ $0.15/ONE) attached to it.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin's Discord
- $1,952,477.39 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 8 months, 1 week ago. Please review their action plans below:

1) daychan has started work.

Check for the bugs. 2) yaclaudes1 has started work.

Will give it a try on a fix. The ledger hardware wallet ordered in regards to this project just arrived.

Learn more on the Gitcoin Issue Details page.

TheAlgorhythmicGuy commented 3 years ago

Has the bug been fixed yet?

mul1sh commented 3 years ago

I think I've fixed this issue as noted earlier, just testing it out now :)

gupadhyaya commented 3 years ago

@mul1sh do you have the fix yet? thanks.

mul1sh commented 3 years ago

@gupadhyaya Yes, but let me push tomorrow once I have tested in a nano X device which I'm purchasing today. So far I have done all my testing on a nano S, but I want to see if the fix works in the nano X and then I push 🙂

mul1sh commented 3 years ago

It's still crashing for some reason in the nano X, it's what i'm fixing now

gupadhyaya commented 3 years ago

got it. thanks @mul1sh please update here once you have the fix ready.

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 6864.9452 ONE (720.96 USD @ $0.11/ONE) attached to this issue has been cancelled by the bounty submitter

Questions? Checkout Gitcoin Help or the Gitcoin's Discord
$1,730,675.48 more funded OSS Work available on the Gitcoin Issue Explorer

gupadhyaya commented 3 years ago

@mul1sh any update on this? thanks.

mul1sh commented 3 years ago

@gupadhyaya I thought the issue had been cancelled, so I stopped working on it. If it's still open, I'll PR by this coming Tuesday 🙂

gupadhyaya commented 3 years ago

@gupadhyaya I thought the issue had been cancelled, so I stopped working on it. If it's still open, I'll PR by this coming Tuesday 🙂

it is still open @mul1sh https://gitcoin.co/issue/harmony-one/bounties/22/100025513, can you submit your work?

mul1sh commented 3 years ago

@gupadhyaya Sure will push by this coming Monday, thanks for clarifying 🙂

gupadhyaya commented 2 years ago

@mul1sh any update? if there is a blocker, I can take a look as well. thanks.

matthewwoop commented 2 years ago

Is this still open season? @gupadhyaya

mul1sh commented 2 years ago

@mul1sh any update? if there is a blocker, I can take a look as well. thanks.

Sorry @gupadhyaya I was a bit caught up the last 2 months, but this week I have some free cycles and will solve this issue and PR.