search

harmony-one / bounties

Bounty program is to help the community take part in the development of the Harmony blockchain. It covers from core feature to validator tooling, from dApp development to DeFi integration.
MIT License
59 stars 23 forks source link

Implementation of WalletConnect #82

Open Ssu-OwO opened 2 years ago

Ssu-OwO commented 2 years ago

Description

Implementation of WalletConnect on Staking Dashboard

Context

We've noticed that on Harmony's staking platform there are only Ledger Nano, Math, and Harmony wallets currently available - given WalletConnect being a popular protocol, we wonder if it's possible to implement WalletConnect as one of the supported methods to sign the delegation.

The WalletConnect is a protocol that can be used to sign transactions using mobile wallets that support walletconnect protocol.

Reference

https://docs.walletconnect.org/v/2.0/

Acceptance Criteria

Reward

USD $10,000 equivalent of ONE token

LeoHChen commented 2 years ago

WalletConnect can be a good addition. Can you add more details on the acceptance criteria and scope of work? I am happy to sponsor this bounty.

Ssu-OwO commented 2 years ago

Dear Leo

Nice to e-meet you. I've been in contact with Jack from your team as well!

WalletConnect is an open protocol for connecting wallets to Dapps, and therefore I believe the addition would greatly add value to Harmony's platform.

Since it's an open protocol with detailed documentation, I'd say the project could be breakdown to 3 simple stages:

  1. Research - Study documentation provided by WalletConnect.
  2. Implementation - Add WalletConnect support to Harmony's wallet connection page. Here's a link to WalletConnect's logo assets if the icon for WalletConnect is needed on the webpage. 
  3. Testing - Make sure the web frontend and mobile wallets can successfully communicate.

The addition will need future maintenance to make sure the protocol is most up-to-date though. Hope the above information helps. If you have any questions please let me know.

LeoHChen commented 2 years ago

I've updated the bounty with more details. We will sponsor this bounty. Thanks a lot for your input and suggestion. That's great feedbacks from the community.

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 44474.8294 ONE (10059.67 USD @ $0.23/ONE) attached to it.

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 264 years, 5 months from now. Please review their action plans below:

1) developerfred has started work.

Hi I have experience with walletconnet integrations and with harmonyOne protocol it would be a great privilege to be able to make this integration happen 2) cryptosans has started work.

To be honest, I really admire the the uniqueness of this project. Like you have to proof to dev that you want to support him and not just receive the token. It's really a planned project and I believe it'll be success. Dev you're really smart to I must commend. 3) jessicahamby has started work.

I see there are many contests in steem blockchain to review different dapps so WalletConnect team can connect with such channels to promote this Dapp through various contests. 4) bonaavidaa has started work.

İ will start this job and i do 5) jpldcarvalho has started work.

Hello. I will start working on this issue. I already checked the issue on gh and will perform the implementation according with the WalletConnect documentation. For testing, probably I will need the team help. 6) imkrish7 has started work.

Learn wallet connect and integrate with current existing code 7) theopenfinanceproject has started work.

Reverse engineer wallet connection mechanism for staking dashboard, establish best and cleanest method for integration, Then integrate.

Will start work Monday.

Hopefully done within a week or 2 depending on complexity and my availability.

Alex | OpenSwap

Learn more on the Gitcoin Issue Details page.

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 44474.8294 ONE (10059.67 USD @ $0.24/ONE) has been submitted by:

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 44474.8294 ONE (10514.38 USD @ $0.24/ONE) has been submitted by:

  1. @developerfred
  2. @dimas-riski
  3. @jpldcarvalho

@leohchen please take a look at the submitted work:

LeoHChen commented 2 years ago

@jhd2best please help test this submission.

jhd2best commented 2 years ago

@jhd2best please help test this submission.

sure. will test it these days.

btw. @developerfred do not forget finish record the video for demonstrating the function and upload to Youtube

developerfred commented 2 years ago

@jhd2best ok, I'm doing some tests here.

developerfred commented 2 years ago

@jhd2best done -> https://github.com/harmony-one/staking-dashboard/pull/580#issue-1030692780

developerfred commented 2 years ago

@jhd2best please help test this submission.

sure. will test it these days.

btw. @developerfred do not forget finish record the video for demonstrating the function and upload to Youtube

https://youtu.be/1UamMkS49Co

jhd2best commented 2 years ago

@jhd2best please help test this submission.

sure. will test it these days. btw. @developerfred do not forget finish record the video for demonstrating the function and upload to Youtube

https://youtu.be/1UamMkS49Co

hey @developerfred . thank you for your hard work. howerver. I didn't see the key functions (such as delegate, undelegate, claim, transfer, etc.) in the video shown. can you please add it if it is convenient? This is a necessary operation to prove that the original function is normal.

jhd2best commented 2 years ago

i have already deploy this PR(https://github.com/harmony-one/staking-dashboard/pull/580) on test environment. you can also have a testing by yourself. @developerfred https://6175723ac80df900073c1999--hmny-stake-test.netlify.app

developerfred commented 2 years ago

@jhd2best Thanks, I'm working on MsgDelegate, MsgUndelegate functions now

jhd2best commented 2 years ago

hey @developerfred . how s it going. is there any update?

developerfred commented 2 years ago

hey @developerfred . how s it going. is there any update?

@jhd2best I managed to come up with a solution that would be to make transactions in Hex and only display address One on the frontend, but all transactions and interactions with walletConnect will be done in hex

jhd2best commented 2 years ago

hey @developerfred . how s it going. is there any update?

developerfred commented 2 years ago

Hey @jhd2best I will send the new updates

d-roak commented 2 years ago

Hello @jhd2best, are you still into this issue? I have done some work on it but can't properly test it because I can't set a proper local backend environment. Can you help me out?

The npm run dev does not work, because it is not setted up in the package.json, but even if I run with tsc -w & NODE_ENV=local nodemon -q -w ./dist ./dist/server.js, I can't bootstrap it because of the gcp serviceAccount key that is needed for the database service. How do you usually setup the local environment?

Thanks !!

developerfred commented 2 years ago

@jpldcarvalho I fixed these issues, I had sent the pull request before. I just need to send an update.

ferasawadi commented 2 years ago

any body working on this? is it still available?

developerfred commented 2 years ago

@ferasawadi I am working on!

LeoHChen commented 2 years ago

@developerfred any update? been too long, other people may work on it if you have no time to finish it.

developerfred commented 2 years ago

@LeoHChen wow, I will update this pr. sorry about late

developerfred commented 2 years ago

@LeoHChen Ready now, sorry for the delay. -> https://github.com/harmony-one/staking-dashboard/pull/580

d-roak commented 2 years ago

@LeoHChen This bounty was a "Contest Permissionless" type at GitCoin. I don't think it's fair for @developerfred to be locking this bounty for months just because it sent an early (incomplete) PR. I have been waiting for months for a review... If it was a "Traditional" or "Approval Required" bounty I could agree that it was "locked" to another developer

developerfred commented 2 years ago

@jpldcarvalho as you noticed my pull request is not incomplete

d-roak commented 2 years ago

@developerfred the one 5 months ago was