search

harmony-one / chrome-extension-wallet

Harmony Chrome Extension Wallet
https://chrome.google.com/webstore/detail/harmony-one-wallet/fnnegphlobjdpkhecapkijjdkgcjhkib
60 stars 36 forks source link

remove unneccessary is isValidJson() check #109

Closed datpenguinclub closed 2 years ago

datpenguinclub commented 2 years ago

await.response.json() from fetch always returns a valid json and not a string. So removed redundant call. This was not allowing HRC 721 tokens to be displayed properly.

Fetch document for reference : https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch#supplying_request_options

datpenguinclub commented 2 years ago

@hypnagonia will this also trigger a release pipeline ?? if not it must be triggered - so that the new version is available to update / download

sophoah commented 2 years ago

@datpenguinclub @hypnagonia just took over this so we are still figuring out how to release the update to the chrome store.

datpenguinclub commented 2 years ago

@sophoah please consider this PR too before y'all go through with the next release - 👉 https://github.com/harmony-one/chrome-extension-wallet/pull/110

On Mon, 1 Nov 2021 at 17:07, Soph @.***> wrote:

@datpenguinclub https://github.com/datpenguinclub @hypnagonia https://github.com/hypnagonia just took over this so we are still figuring out how to release the update to the chrome store.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/harmony-one/chrome-extension-wallet/pull/109#issuecomment-955910122, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWIMYIYHOM6EI3W6HABFOXLUJYG6PANCNFSM5G63G25A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.