search

harmony-one / chrome-extension-wallet

Harmony Chrome Extension Wallet
https://chrome.google.com/webstore/detail/harmony-one-wallet/fnnegphlobjdpkhecapkijjdkgcjhkib
60 stars 36 forks source link

Onewallet - add the option to import a list of predifined tokens, instead of doing it one by one #67

Open BrunoMarshall opened 3 years ago

BrunoMarshall commented 3 years ago

The proposal is to add an option to import a list of tokens on the ONEWallet, instead of importing each token separately. currently the team is developing several DEX ( SWOOP, SeeSwap, Unify,) that will work with several tokens. The user need to import each one separately. image

Proposal is that each platform has a list of tokens, that can be imported. the format list need to be agreed and shared to everyone

(tokens syntetic names are just for the example): Import: USDs 0x5f089d2ea9008dada6f05b8c78f25233fd27f966 BTCs 0xea10a239c4fcaf31225efdb4dc634aeff42c585d ETHs 0x7334d832bfc79f59df8bc092cba3ae687faed7fa XRPs 0x33bA9Bf6cF19bCd91E2f745C0ac4c05A192c069F BCHs 0x4a6B66F5B955cA3FB51c59c272554Ee45bDb2239 BNBs 0xbCf0038d69372773a966166d35Ac35B7B6914D33 DOTs 0x120aEeA98f391cBc7f1DCA79c5eDD8f329856258 LINKs 0x62D8fEacf66E39Ed9179dB4f68581dBBa159457A ADAs 0xDD697498B26F135C5C331022F17BA368A89489c1 LTCs 0x10580fD9aB6DF1E836708C553165f1002D6ff2F9 EOSs 0xf54f91a34C0280a8F3c11819a5364E4A67181ECe

yelllowsin commented 3 years ago

Another idea is to just whitelist/add these contracts into the One Wallet code for all users since they are legit contracts anyway. Some other wallets like Myetherwallet go even further and implement a logic that:

If wallet has funds in any any of the whitelisted contracts, shows the token. The user has still the option to add it manually if he wants.

Only worry is that this could be resource consuming. You would have to do this check every time you select the Token tab.

mirrormirage0 commented 3 years ago

I suggest that we have something like "Lists" similar to uniswap.

We could then have "Harmony Verified List", with all tokens vetted by us.

This feature will be important from a user perspective to avoid adding the wrong token contract/address.

image image image

yelllowsin commented 3 years ago

I suggest that we have something like "Lists" similar to uniswap.

We could then have "Harmony Verified List", with all tokens vetted by us.

This feature will be important from a user perspective to avoid adding the wrong token contract/address.

image image image

I like this idea, seems much better. Do we have ENS names on Harmony already? I am not sure we have this yet, but i see it accepts lists via https and IPFS as well, so we could use these if we don´t have ENS.

imyugioh commented 3 years ago

I think harmony doesn't have any official HRC20 Token lists yet. So I am not able to show the list like uniswap for now. @yelllowsin @mirrormirage0 @BrunoMarshall What do you think? Correct me if I am wrong

mirrormirage0 commented 3 years ago

@raptor1001 If we can have a simple 2 step workflow as follows, it would be great 1) Harmony Team member submits the Token address 2) Reviewer has option to approve/reject the submitted Token Address 3) If approved, the Token address appears in the List of "Verified Harmony Token" e.g. Ganesha could submit the BUSD/ONE contract addresses for ETH-HMY bridge