harmony-one / chrome-extension-wallet

Harmony Chrome Extension Wallet
https://chrome.google.com/webstore/detail/harmony-one-wallet/fnnegphlobjdpkhecapkijjdkgcjhkib
61 stars 36 forks source link

Chrome crash removes all wallets #96

Open bmgalego opened 3 years ago

bmgalego commented 3 years ago

When chrome crashes sometimes it removes all wallets from the extension and it only happens to Harmony wallet, metamask for instance doesn't happen. I have tried to crash the chrome to see if happens but couldn't reproduce the same result so don't know how to test this. But I found some code in the metamask repo that may help this.

I think this is where harmony deletes the wallets https://github.com/harmony-one/onewallet/blob/master/src/services/StorageService.js#L14

Metamask does something similiar https://github.com/MetaMask/metamask-extension/blob/af3c740b1b4e3cbaf78611b98c6af95f51bfcae2/app/scripts/lib/local-store.js#L54 https://github.com/MetaMask/metamask-extension/blob/af3c740b1b4e3cbaf78611b98c6af95f51bfcae2/app/scripts/lib/util.js#L137

This is easy implemented and I it works for metamask, let me know if this is ok and I could make a PR for this