currently all validators try to confirmTransaction even on the transactionIds that are already executed due to 2 out of 3 already confirmed. this leads to failure of confirmTransaction, but wasting tx fee. add a check of notExecuted (https://github.com/harmony-one/ethhmy-bridge/blob/master/contracts/lib/MultiSigWallet.sol#L75) call before a validator sends confirmTransaction to save on the tx fee.
potvik
commented
3 years ago
currently all validators try to confirmTransaction even on the transactionIds that are already executed due to 2 out of 3 already confirmed. this leads to failure of confirmTransaction, but wasting tx fee. add a check of notExecuted (https://github.com/harmony-one/ethhmy-bridge/blob/master/contracts/lib/MultiSigWallet.sol#L75) call before a validator sends confirmTransaction to save on the tx fee.