search

harmony-one / harmony

The core protocol of harmony
https://harmony.one
GNU Lesser General Public License v3.0
1.46k stars 286 forks source link

Removed threshold 10 epochs #4671

Closed Frozen closed 2 months ago

Frozen commented 3 months ago

Removes threshold for 10 blocks for devnet crosslinks fix.

sophoah commented 3 months ago

Hey @Frozen, instead of removing the crosslink outright, can we first check whether it has already been processed? If it has, then we can proceed with the removal. This particular piece of code was a legitimate removal due to a previous mainnet issue where old pending crosslinks, which had already been processed, were stuck in the database.

Frozen commented 3 months ago

Hey @Frozen, instead of removing the crosslink outright, can we first check whether it has already been processed? If it has, then we can proceed with the removal. This particular piece of code was a legitimate removal due to a previous mainnet issue where old pending crosslinks, which had already been processed, were stuck in the database.

As i can understand the next line of code does what you expect link