search

harmony-one / harmony

The core protocol of harmony
https://harmony.one
GNU Lesser General Public License v3.0
1.46k stars 286 forks source link

Fix for possible race for new block post consensus processing. #4677

Closed Frozen closed 1 week ago

Frozen commented 2 months ago

Fix for possible race for new block post consensus processing.

sophoah commented 2 months ago

this PR seems to break consensus, travis tests are not moving

Waiting for localnet to boot...
Waiting for localnet to boot...
Localnet booted.
Waiting for epoch 2...
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
sophoah commented 2 months ago

could you explain why this PR may fix the possible race condition with the post consensus process ?

Frozen commented 2 months ago

could you explain why this PR may fix the possible race condition with the post consensus process ?

It removes https://github.com/harmony-one/harmony/pull/4677/files#diff-255a5cdd5516e7293e60a47a92503360676ddffb7e48e505598a589753b568c2L672 which execution is not predictable.

Frozen commented 1 week ago

This PR is unstable, i will close it