harmony-one / harmony

The core protocol of harmony
https://harmony.one
GNU Lesser General Public License v3.0
1.46k stars 286 forks source link

Feature: broadcast vote power #4683

Closed Frozen closed 3 weeks ago

Frozen commented 2 months ago

Feature: broadcast vote power

sophoah commented 1 month ago

@Frozen were you able to test that PR in localnet and confirm the VP and api calls are working fine ? hmy_getLastSigningPower at the current state is only working when this is call on the leader, now this one should work on all nodes.

Frozen commented 1 month ago

@Frozen were you able to test that PR in localnet and confirm the VP and api calls are working fine ? hmy_getLastSigningPower at the current state is only working when this is call on the leader, now this one should work on all nodes.

i have hmy_getLastSigningPower and hmy_getLastSigningPower2 methods to compare results, and i'm waiting for watchdog localnet integration to confirm that everything works as expected.

mur-me commented 1 month ago

@Frozen, please confirm that you are unblocked and have watchdog locally

GheisMohammadi commented 3 weeks ago

Looks good to me. We need to test the LastSignPowerRequest in the localnet. Other than that, everything is good. Thanks!