harmony-one / harmony

The core protocol of harmony
https://harmony.one
GNU Lesser General Public License v3.0
1.47k stars 289 forks source link

Verbose logs by default on localnet #4750

Closed Frozen closed 1 month ago

Frozen commented 1 month ago

Verbose logs by default on localnet.

sophoah commented 1 month ago

@Frozen, I propose keeping deploy.sh unchanged and instead updating Makefile and test/debug.sh by adding a new target, something like make debug-verbose. This will allow us to easily enable more detailed logging when troubleshooting issues on localnet without altering the existing flow.

cc @mur-me, what do you think ?

mur-me commented 1 month ago

@Frozen, I propose keeping deploy.sh unchanged and instead updating Makefile and test/debug.sh by adding a new target, something like make debug-verbose. This will allow us to easily enable more detailed logging when troubleshooting issues on localnet without altering the existing flow.

cc @mur-me, what do you think ?

I've started to type my comment, but after some time it started to become full and ready to go solution - https://github.com/harmony-one/harmony/pull/4755

sophoah commented 1 month ago

closing this one since #4755 is doing the work already