brucdarc
commented
2 years ago I also combined the existing functionality for events with this new functionality for the execute event to save on code reuse. Theoretically it would be less gas to separate them, but would result in a lot of code duplication. If anyone has thoughts on this let me know.
On more deliberation, I have decided to separate the functionality. Added helper functions to reduce code duplication to the best of my ability.
Uses the event structure for mint/burn ect events to add an event where any user can emit an event that will allow code to be executed on the other chain.
User must call the validateAndExecuteProof function separately providing the contract address to listen for events from. The event passes the address to call and a bytes array of arbitrary data. The bridge contract then calls the specified address with the function signature HorizonExecute(address,bytes). The address passed is the address of the contract on the other side of the bridge that emitted the event. This allows permissioning of the other side contract specifcally, so that not any contract can emit the event and trigger behavior of contracts on the other chain.
Leaving this PR in draft for now because I am having problems getting the proof generated from the DagProof CLI file to be verified by the validateMPTProof of EthereumProver.sol, therefore preventing me from accessing and testing any of the new code for this feature at the mement.