Can't sign with ledger after settings update

harmony-one / multisig-react

Harmony multisig react app

MIT License

5 stars 12 forks source link

Can't sign with ledger after settings update #11

Closed hypnagonia closed 2 years ago

hypnagonia commented 2 years ago

after safe's settings update, it's not possible to sign a transaction with ledger anymore. throws

inpage.js:1 MetaMask - RPC Error: MetaMask Message Signature: Error: Ledger: Only version 4 of typed data signing is supported {code: -32603, message: 'MetaMask Message Signature: Error: Ledger: Only version 4 of typed data signing is supported', data: {…}}

hypnagonia commented 2 years ago

fixed was related to trailing bytes adjusting, was not implemented for typed messages https://github.com/gnosis/safe-react/blob/9469f090826aae691e7e5413534744a804fc8900/src/logic/safe/transactions/offchainSigner/utils.ts#L37-L42