harmony-one / multisig-react

Harmony multisig react app
MIT License
5 stars 12 forks source link

Update latest non-breaking changes from gnosis/safe-react #2

Open gupadhyaya opened 3 years ago

gupadhyaya commented 3 years ago

Multisig frontend is facing some flickering issues when many transactions are queued for confirmations. This could be an UI related bug. I recommend updating the frontend with latest non-breaking changes from https://github.com/gnosis/safe-react. Unfortunately, this repo was not forked from upstream, which may increase the complexity of patching from upstream.

gupadhyaya commented 3 years ago

@ethlocker check the safe: https://multisig.harmony.one/#/safes/0x30af69A3f4a6f266961313Ce0943719dF4A8AA10/transactions

you can see the flickering of the transactions. You may look at the transaction with nonce: 19, whose created/executed date changes every 30 second or so, making it move around.

before after

you can also query the backend data using: https://multisig.t.hmny.io/api/v1/safes/0x30af69A3f4a6f266961313Ce0943719dF4A8AA10/all-transactions/?limit=100&queued=true&trusted=true

which always has the consistent result.

hypnagonia commented 3 years ago

flickering was caused by environment configuration. should be gone by now