search

harmony-one / sdk

Javascript SDK of Harmony protocol.
MIT License
91 stars 44 forks source link

Replace scrypt-shim with scrypt.js; add test #128

Closed ArtemKolodko closed 2 years ago

ArtemKolodko commented 2 years ago

1) scrypt-shim library is replaced by scrypt.js image 2) Added test suit for keystore to test scrypt.js compatibility 3) Found 1 diff in error handling: on test check encrypt (invalid "level" option) scrypt.js throws an error with text "N must be > 0 and a power of 2", scrypt-shim with text "Invalid scrypt params"

gupadhyaya commented 2 years ago

@ArtemKolodko @MaxMustermann2 looks like 1 test is failing in yarn test:src. specifically, keystore.test.ts

✕ check encrypt (private key and password are undefined) (12ms)

can u fix this? thanks.

gupadhyaya commented 2 years ago

@ArtemKolodko @MaxMustermann2 can you guys also fix the broken tests under e2e/src?