search

harmony-one / sdk

Javascript SDK of Harmony protocol.
MIT License
92 stars 43 forks source link

fix broken e2e test #47

Closed denniswon closed 4 years ago

denniswon commented 4 years ago

Before fix:

 FAIL  e2e/src/blockchain.e2e.ts
  e2e test blockchain
    ✓ should test net_peerCount (4ms)
    ✓ should test net_version (2ms)
    ✓ should test hmy_protocolVersion (1ms)
    ✓ should test hmy_blockNumber (2ms)
    ✕ should test hmy_getBlockByNumber (20ms)
    ✕ should test hmy_getBlockByHash (14ms)
    ✓ should test hmy_getBalance (6ms)

  ● e2e test blockchain › should test hmy_getBlockByNumber

    Validation failed for miner,should be validated by isAddress

      at Object.validateArgs (packages/harmony-utils/src/utils.ts:1104:17)
      at checkBlockData (e2e/src/blockchain.e2e.ts:64:24)
      at e2e/src/blockchain.e2e.ts:37:12
      at step (node_modules/tslib/tslib.js:141:27)
      at Object.next (node_modules/tslib/tslib.js:122:57)
      at fulfilled (node_modules/tslib/tslib.js:112:62)

  ● e2e test blockchain › should test hmy_getBlockByHash

    Validation failed for miner,should be validated by isAddress

      at Object.validateArgs (packages/harmony-utils/src/utils.ts:1104:17)
      at checkBlockData (e2e/src/blockchain.e2e.ts:64:24)
      at e2e/src/blockchain.e2e.ts:53:12
      at step (node_modules/tslib/tslib.js:141:27)
      at Object.next (node_modules/tslib/tslib.js:122:57)
      at fulfilled (node_modules/tslib/tslib.js:112:62)

After fix 

Test Suites: 3 passed, 3 total
Tests:       20 passed, 20 total
Snapshots:   0 total
Time:        17.543s
Ran all test suites.
✨  Done in 18.36s.