search

harmonydata / harmony

The Harmony Python library: a research tool for psychologists to harmonise data and questionnaire items. Open source.
https://harmonydata.ac.uk
MIT License
7 stars 12 forks source link

Upgrade Harmony to latest Pydantic 2.8.2 or later #50

Closed woodthom2 closed 2 weeks ago

woodthom2 commented 1 month ago

We are using an old version of Pydantic

olp-cs commented 1 month ago

Is this issue still available for someone to take on? I can start with it.

A migration guide is available here: https://docs.pydantic.dev/latest/migration/

woodthom2 commented 1 month ago

Hi yes it is totally available and nobody has looked at it. Thanks so much for offering, this would be really helpful! When I tried upgrading Pydantic there are all sorts of errors that come up because of broken backwards compatibility. While you're looking into it's, if you are able to switch some of the logging functions from the vanilla Python print to proper logging (I think defined somewhere in the project in logger.py or somewhere that would be fantastic too.

On Fri, 19 Jul 2024, 18:11 olp-cs, @.***> wrote:

Is this issue still available for someone to take on? I can start with it.

A migration guide is available here: https://docs.pydantic.dev/latest/migration/

— Reply to this email directly, view it on GitHub https://github.com/harmonydata/harmony/issues/50#issuecomment-2239701854, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUBTVIL6T2Z4O566RSOEC3ZNFCEJAVCNFSM6AAAAABLEENCP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZZG4YDCOBVGQ . You are receiving this because you authored the thread.Message ID: @.***>

olp-cs commented 1 month ago

Thank you for the explanation! I will look into it and check how to fix the compatibility issues. I'll look into logging as well.

woodthom2 commented 1 month ago

Thanks!

On Fri, 19 Jul 2024, 18:33 olp-cs, @.***> wrote:

Thank you for the explanation! I will look into it and check how to fix the compatibility issues. I'll look into logging as well.

— Reply to this email directly, view it on GitHub https://github.com/harmonydata/harmony/issues/50#issuecomment-2239732343, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUBTVLUJPJPKYVK6QZWE4TZNFEXTAVCNFSM6AAAAABLEENCP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZZG4ZTEMZUGM . You are receiving this because you authored the thread.Message ID: @.***>

woodthom2 commented 1 month ago

BTW pydantic would need to be upgraded in both API and Python repos

On Fri, 19 Jul 2024, 20:13 Thomas Wood, @.***> wrote:

Thanks!

On Fri, 19 Jul 2024, 18:33 olp-cs, @.***> wrote:

Thank you for the explanation! I will look into it and check how to fix the compatibility issues. I'll look into logging as well.

— Reply to this email directly, view it on GitHub https://github.com/harmonydata/harmony/issues/50#issuecomment-2239732343, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUBTVLUJPJPKYVK6QZWE4TZNFEXTAVCNFSM6AAAAABLEENCP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZZG4ZTEMZUGM . You are receiving this because you authored the thread.Message ID: @.***>

olp-cs commented 1 month ago

I submitted a pull request to upgrade Pydantic in the current repo. I will look into Harmony API as well.

I couldn't find the logging settings; perhaps it's better to create a separate ticket to address this later.

P.S. By the way, I still have to run the unit tests and integration tests in the API repo.