Closed DjDeveloperr closed 2 years ago
Should I be using unique Symbols instead of #private fields (like _ipcHandle
)?
Should I be using unique Symbols instead of #private fields (like
_ipcHandle
)?
private fields are fine. _ipcHandle
is a symbol because I didn't want users to use DiscordIPC
's constructor directly
Private properties seem to have some problem with the way DiscordIPC object is being created
Hmm yeah downside of using private properties. Let's just use Symbols for now - I really don't want users to be able to use the constructor as its not part of the public API
Tested on Ubuntu VM, seems to work
How should events work? Should it extend a EventEmitter (std or x/event), EventTarget + on* or a just Async Iterator?
How should events work? Should it extend a EventEmitter (std or x/event), EventTarget + on* or a just Async Iterator?
Preferably async iterators
towards #1
getIPCPath
which returns IPC-pipe path based on OS.findIPC
which returns path that is currently active.Had a few questions before I could start working on support for more commands, for which I've made
NOTE
comments.Pretty much WIP, haven't tested as I use Windows and there's no unix socket support.. I'll try on a VM.
There's cool things like editing voice setting, creating game lobbies, selecting text channels, etc. which discord-ipc can do 😉