search

harmslab / TreeViewer

Interactive Evolutionary Tree Viewer using D3.js
BSD 2-Clause "Simplified" License
2 stars 3 forks source link

Rendering customization window #19

Closed Zsailer closed 10 years ago

Zsailer commented 10 years ago

This is a very basic customization modal. It's simply a window that pops up over the page with some options to change the final rendering. I've applied it to the tree_viewer only. Right now, it only changes the rendering of the tree between static and dynamic view.

Two things:

  1. I've created a generic modal object that can be populated to fit various visualization representations
  2. Each visualization can have an Options object that holds specific customizations to that type of visualization.

I have also done some reorganization of the objects in hopefully a more intelligent way. Originally, I was making copies of objects where it wasn't necessary.

There is still tons of work to be done. I'm opening this PR early to show my idea here. It's not ready to be merged.

Zsailer commented 10 years ago

This is the prototype for the feature request mentioned in issue #15

Zsailer commented 10 years ago

@jacmarjorie I think I'm going to go ahead and merge this pull request today. Then, I can do the large refactoring of the separate projects... with components, dependencies, and base classes in separate submodules.

Do you have any objections?

jacmarjorie commented 10 years ago

Things look good, no objections.