harmslab / TreeViewer

Interactive Evolutionary Tree Viewer using D3.js
BSD 2-Clause "Simplified" License
2 stars 3 forks source link

Phylo: Collapsable Clades #5

Open jacmarjorie opened 9 years ago

jacmarjorie commented 9 years ago

Collapse subtree into clades that reflect taxa composition

Zsailer commented 9 years ago

Clades are represented as isosceles triangles? What would the size of the clade represent... the number of children nodes in that clade?

jacmarjorie commented 9 years ago

Assuming a sideways triangle: Height = difference in depth between most recent common ancestor (root of subtree clade) and the taxa (leaf) with the longest branch Width = number of taxa in a clade (which equals the # of leaves of a subtree)

jacmarjorie commented 9 years ago

Beginning stages of clade formation for the static tree. Currently testing different implementations of collapsible functionality, which are up for discussion. I'm anticipating this will be buggy / a bit messy for a while.

The plan is to use the static tree clade formation as a good starting point before diving into the dynamic tree clades. This may require independent initial and update functions. If the two tree implementations begin to diverge too much, we may want to discuss creating static and dynamic tree objects which we can instantiate inside tree viewer.

Zsailer commented 9 years ago

I see you have a clades branch in your forked repo. Go ahead and open a pull request against this master branch whenever you like... even if it's not finished. We can leave it open as a pull request until you feel like its stable to merge.