Open biophyser opened 6 years ago
The load function in v0.5.0
won't work because there is no track_in_history
functionality in that version. Needs migration from v0.4.1
.
I think we need to add the load
functionality in PR #16. Load needs to be away of the history file as well.
As I was thinking about the load
functionality more, I realized we need to make a decision here: what format should we use to save PhylogeneticsProject
's.
The simplest way (and the way I've previously done it) is using Python's pickling serialization protocol. There many drawbacks to this method (just google "Python pickle is bad").
I think we should use a format provided by PhyloPandas. I'm in favor of JSON (using the to_json
method). JSON is lightweight, human readable, and fast.
What do you think?
I think JSON is the way to go. Besides everything you listed there are multiple ways to parse and write JSON, I'm thinking if a user wants to take the data out of python.
When trying to read data into a project that already had data loaded (like when restarting a notebook) an exception occurs:
But the
.load
function does not exist:Putting this here so I remember...