feat: use delegate token from existing secret

[mmorejon]

Secrets are managed out of the helm chart lifecycle when secret management tools are in place. Therefore, the chart should bring the option to use existing secrets in the namespace.

[mmorejon]

Hi @mdmilic, here you'll find answers to your questions. I've updated the helm chart to allow the use of different secrets for delegateToken and upgraderToken.

Let me know if you have more questions.

Solution details

• Helm chart will use different variables to define the external secret, existingDelegateToken and existingUpgraderToken.
• The secret used for existingDelegateToken must include the DELEGATE_TOKEN key.
• The secret used for existingUpgraderToken must include the UPGRADER_TOKEN key.
• The same secret name can be used for both variables if it has both keys mentioned above.
• Multiple deployments can share the same secret names. The use of existent secrets isn't a helm chart responsibility. Teams can use the desired pattern based on the first points described above.
• Recommended scenario: two new secrets created in the namespace per deployment.

I tested the following scenarios

All values empty

• when delegateToken, existingDelegateToken and existingUpgraderToken empty.
• two new secrets are created by helm with DELEGATE_TOKEN and UPGRADER_TOKEN values empty.

Only with delegate token

• delegateToken not empty
• existingDelegateToken and existingUpgraderToken empty
• two new secrets are created by helm with DELEGATE_TOKEN and UPGRADER_TOKEN using delegate token.

delegate token with existingDelegateToken

• delegateToken and existingDelegateToken not empty
• existingUpgraderToken empty
• one secret is created by helm with UPGRADER_TOKEN using delegate token.
• the deployment manifest will use the secret name defined in existingDelegateToken.

delegateToken with existingUpgraderToken

• delegateToken and existingUpgraderToken not empty
• existingDelegateToken empty
• one secret is created by helm with DELEGATE_TOKEN using delegate token.
• the upgrader job will use the secret name defined in existingUpgraderToken.

existingDelegateToken and existingUpgraderToken

• existingDelegateToken and existingUpgraderToken not empty
• no secret created by helm
• deployment and upgrade job manifest with use the secret names