search

harness / delegate-helm-chart

Other
6 stars 20 forks source link

allowing specific image repo and setting cpu limits #83

Closed djsly closed 5 months ago

djsly commented 6 months ago

Our clusters requires the CPU limit to be present or else a default of 250m is set, so we need to ensure the chart allows for it. Also, when using charts, the best practice is to use the default pinned version within the chart while allowing the registry and/or the repository to be changed (cached/passthrough registries) and the tag to be overwritten (from the one in the chart)

CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.

AnupamIO commented 6 months ago

@AnupamIO I have bumped the version to 2.0.0 to mark as Major bump which requires configuration change due to the non backward compatibility

checking within team, if that's okay, will revert on this.

djsly commented 6 months ago

@mdmilic / @AnupamIO can you please review, if all good, could I get this push and visible on artifacthub.io?

Thanks !

djsly commented 6 months ago

@mdmilic / @AnupamIO any updates here ? thanks !