search

harness / ff-java-server-sdk

Java Server SDK for integrating with Harness Feature Flag service.
Apache License 2.0
7 stars 21 forks source link

Metrics are not flushed when the client is closed #202

Open youngm opened 23 hours ago

youngm commented 23 hours ago

It would be nice if the client attempted to flush its metrics queue on close(). That would help make analytics a bit more accurate.

erdirowlands commented 7 hours ago

Hi @youngm, this is a great suggestion and it's something that we wish we added to the SDKs from day 1.

The behaviour where we do not flush metrics on close is consistent with the majority of our SDKs and we would add this on a case by case basis, but have no plans to across the board.

For Java specifically, I have reviewed the code and could feasibly introduce it in the same release for https://github.com/harness/ff-java-server-sdk/issues/201 so will aim for that. :-)

I'll keep you updated as I work on both issues.