harness / ff-ruby-server-sdk

Ruby Server SDK for integrating with Harness Feature Flag service.
https://www.harness.io/
Apache License 2.0
3 stars 5 forks source link

Not all of your classes are declared within modules #36

Open mikeappell opened 8 months ago

mikeappell commented 8 months ago

Hi folks,

I just ran into an issue that took me quite a while to track down the underlying cause of. It eventually turned out that ff-ruby-server-sdk declares a class Operators without namespacing it in a module, and we declare an Operators module in our own application code, and these two declarations clash.

My understanding of gems is that you'd want to namespace all of your declared classes to prevent clashing with the applications which make use of your gem. You do some namespacing, e.g. Module Ff/Ruby/Server/Sdk but not globally.