search

harness / ff-ruby-server-sdk

Ruby Server SDK for integrating with Harness Feature Flag service.
https://www.harness.io/
Apache License 2.0
3 stars 5 forks source link

[FFM-5355] changed prereq matches from value to identifier #6

Closed bmjen closed 1 year ago

bmjen commented 1 year ago

WHAT

Evaluation checks for Pre-Req flags were incorrectly implemented in some Server SDKs, as they were checking for value instead of identifier this was uncaught previously because the test cases used boolean flags which had the same string for identifier and value.

FIX Updates the PreReq check to check against a feature's identifier instead of value.

TEST The test cases were updated to properly test with a flag that has identifier that isn't equal to value. The tests on this SDK were updated to use the new test cases.

swarmia[bot] commented 1 year ago

✅  Linked to Bug FFM-5355 · Update Ruby SDK to Match Variations for Prereqs With Identifier Instead of Values.

bmjen commented 1 year ago

I updated the test evaluations to support the new generated test cases... but I wasn't able to verify that the tests failed on the old version of the code base that evaluated pre-reqs incorrectly. The tests still passed. Will try to debug more tomorrow.