search

harness / gitness

Gitness is an Open Source developer platform with Source Control management, Continuous Integration and Continuous Delivery.
https://gitness.com
Apache License 2.0
31.93k stars 2.78k forks source link

Either support external secret plugins in community or make it very clear in the docs that community doesn't support it #3270

Open cweagans opened 1 year ago

cweagans commented 1 year ago

There is nothing that I can see on https://docs.drone.io/secret/ or any of the child pages that would indicate that external secret plugins don't work. However, https://github.com/harness/drone/blob/master/plugin/secret/external_oss.go is a no-op and would never actually attempt to look up a secret from an external plugin, nor would it ever give any indication that it's not going to work: it just silently fails.

I spent a lot of time writing a secret plugin for a secret management solution that I've been working on and it's extremely frustrating to now find out that it won't work as expected because that functionality is locked behind a paywall. It's doubly frustrating that I chose Drone as one of the two systems to integrate with specifically because you indicated you had support for external secret plugins and now it turns out that's not the case :/

Please either mv external_oss.go external.go or update the docs to make it clear that external secrets are an enterprise thing.

ShruthiHubb commented 1 year ago

Hi @cweagans thanks for raising the issue. I have taken this for discussion to the internal team and I will revert ASAP