harness / gitness

Gitness is an Open Source developer platform with Source Control management, Continuous Integration and Continuous Delivery.
https://gitness.com
Apache License 2.0
32.09k stars 2.8k forks source link

[Feature request] SSH Cloning #3392

Open MarioGK-AutoSystem opened 11 months ago

MarioGK-AutoSystem commented 11 months ago

It would be great to clone the repositories using an SSH key instead of login and password api key

avanmathur1 commented 11 months ago

@MarioGK-AutoSystem thanks for your feedback! We will look into adding this support and keep you updated

johannesHarness commented 11 months ago

@MarioGK-AutoSystem wanted to provide some more context on this. While GIT prompts a username and password during clone via http/https, we actually expect an API KEY to be provided as password, as it has limited lifetime and can be revoked. Your Gitness username + password won't actually work with git. If you are being asked for the credentials on every pull/push, you can try to configure your git with a credentials manager, which will allow git to store the credentials for the domain locally and reuse them the next time.

This is similar to what Github is doing, where they explicitly disabled username + password credentials for git protocol due to security concerns (See they blob post)

MarioGK-AutoSystem commented 11 months ago

@MarioGK-AutoSystem wanted to provide some more context on this. While GIT prompts a username and password during clone via http/https, we actually expect an API KEY to be provided as password, as it has limited lifetime and can be revoked. Your Gitness username + password won't actually work with git. If you are being asked for the credentials on every pull/push, you can try to configure your git with a credentials manager, which will allow git to store the credentials for the domain locally and reuse them the next time.

This is similar to what Github is doing, where they explicitly disabled username + password credentials for git protocol due to security concerns (See they blob post)

Edited my issue to say api key instead of password.

Yeah i think ssh keys are more convenient and safer than API keys for git operations

sachaw commented 11 months ago

This feature should be implemented along with commit signing validation. A user should be able to register ssh keys and mark them as authentication and/or signing keys

fucksophie commented 10 months ago

This seems to be a pretty big blocker to me as to why I won't use Gitness. SSH key verification and authenication would be perfect..

amatiasq commented 9 months ago

Yep, this issue would not be with SSH.

$ git push gitness main                                                            
Enumerating objects: 2498, done.
Counting objects: 100% (2498/2498), done.
Delta compression using up to 12 threads
Compressing objects: 100% (1420/1420), done.
error: RPC failed; HTTP 413 curl 22 The requested URL returned error: 413
send-pack: unexpected disconnect while reading sideband packet
Writing objects: 100% (2498/2498), 20.83 MiB | 9.95 MiB/s, done.
Total 2498 (delta 1414), reused 1629 (delta 975), pack-reused 0
fatal: the remote end hung up unexpectedly
Everything up-to-date
mikekuzak commented 7 months ago

+1 without SSH keys this is no bueno

pryorda commented 6 months ago

Yeah.. No ssh or ssh over https is a no go :/

notarock commented 4 months ago

Is there an ETA for this? I would love to use gitness and this is the only feature holding me back...

kbaegis commented 3 months ago

+1

This is not the opencore model you're looking for.

pwolf-harness commented 3 months ago

Hi, everyone. We appreciate the feedback and are actively working on adding SSH to Gitness to an upcoming release.

cocoonkid commented 2 months ago

Excellent. This is really missing.