Closed alexohneander closed 10 months ago
@willzhang @arya-harness @abhinav-harness Accidentally closed the pull request during the last commit and could not reopen it. It is the same request as #3397 with the additional env vars.
I found that the Docker Dind section has been deleted. Is this not needed, or is there any other solution?
docker:
enabled: true
image: docker:24.0.3-dind
resources: {}
# limits:
# cpu: 100m
# memory: 128Mi
# requests:
# cpu: 100m
# memory: 128Mi
or can we mount host docker.sock or containerd.sock ? Uncertain whether gitness supports containerd
host:
docker:
sock: /var/run/docker.sock
containerd:
sock: /var/run/containerd/containerd.sock
crio:
sock: var/run/crio/crio.sock
volumes:
Perhaps in the k8s environment, gigness directly communicates with the k8s API and runs jobs by creating multiple worke pods?
or use drone-runner https://github.com/drone-runners/drone-runner-kube
thanks @alexohneander for the contribution!
@willzhang good point, we would want a docker:dind
container added for pipeline execution, similar to what we have in the official Drone help chart. See https://github.com/drone/charts/blob/master/charts/drone-runner-docker/templates/deployment.yaml#L40
adding @jimsheldon as a reviewer (he is the creator of the Drone chart)
@willzhang @bradrydzewski I made a mistake yesterday. We still need the dind and that definitely has to go back in. I'll adjust it.
Is there anything missing or can I tweak, I would love to do that. 😃
there is no index.yaml file for using these templates as a helm chart. opened issue: https://github.com/harness/gitness/issues/3512#issue-2290930581
Added helm deployment so you can quickly deploy it to your Kubernetes cluster.
The deployment consists of: