search

harningle / fia-doc

Parse FIA documents to get underlying tyre compound
8 stars 1 forks source link

Columns Renamed #3

Open jeanbernard opened 2 months ago

jeanbernard commented 2 months ago

Renamed the columns in the dataframe to have consistency with the other PDFs in the demo notebook:

Original Renamed
N° NO
Car TEAM
Driver DRIVER
harningle commented 2 months ago

This is nice. I actually meant something else last time. Sorry for the confusion.

The demo notebook is good: it shows how we go from a PDF to a table, though the table column naming is not perfect. That's fine, as it's a just demo.

But when (in production) we want to load the table into our database, naming is important. The workflow will be like: after FIA publishes something, we run parse_pu_allocation.py, which gives us a dataframe or json or whatever. Finally, the json goes into the database. If parse_race_history_chart.py use driver_no as the driver number, then in parse_pu_allocation.py we probably shall also use driver_no, instead of N°.

Would you please create a script called parse_pu_allocation.py, which works like parse_race_history_chart.py? You can start a new PR, or simply add things here. Thanks a lot!