haroldadmin / Vector

Kotlin Coroutines based MVI architecture library for Android
https://haroldadmin.github.io/Vector/
Apache License 2.0
193 stars 9 forks source link

Compatibility with Android Studio 3.4 #5

Closed Quentin1010 closed 4 years ago

Quentin1010 commented 4 years ago

Could it be possible to be able to build this project on Android Studio 3.4? Having to move to a beta version of AS to run it is a blocker for me...

haroldadmin commented 4 years ago

Android Studio 3.5 is already at RC 3, and will be released to stable very soon. They release weekly, and the last release was on Aug 8. So it should only take a couple of days.

haroldadmin commented 4 years ago

If you can not wait for a couple of days, I can maybe make separate branch with a lower AGP version so that you can build it on AS 3.5. Do you think that is a good idea?

Quentin1010 commented 4 years ago

Yep I can wait for that to happen. I just found it weird as a practice to give an open project like that, np ^^

haroldadmin commented 4 years ago

AS 3.5 is stable, and I have updated the project to use AGP 3.5.0, and Kotlin 1.3.50. Commit.