Migrate to ViewBinding in the project

haroldadmin / WhatTheStack

See a pretty error screen when your Android app crashes

Apache License 2.0

245 stars 22 forks source link

Migrate to ViewBinding in the project #16

Closed haroldadmin closed 4 years ago

haroldadmin commented 4 years ago

WhatTheStack started as a small project to only display very basic information on a crash. findViewById sufficed for this purpose.

However, the complexity of the error screen has increased since then, and is going to continue in that direction. Therefore it makes sense to now refactor the project to migrate to ViewBinding instead.

Tasks:

Enable ViewBinding in the project's build configuration
Migrate to ViewBinding in the sample app
Migrate to ViewBinding in the library

shivam21 commented 4 years ago

hi @haroldadmin any reason for not using kotlin synthetics?

haroldadmin commented 4 years ago

Yes. Kotlin Synthetics don't deal with view nullability in different configurations. They also don't work well for multi-module projects.

shivam21 commented 4 years ago

thanks for the info. would love to work on view bidings to know more. @haroldadmin Can I work on this issue?

haroldadmin commented 4 years ago

Sure. Assigning it to you.

shivam21 commented 4 years ago

Thanks @haroldadmin raised the PR Please check.