haroldmodesto / minimalist

Automatically exported from code.google.com/p/minimalist
0 stars 0 forks source link

inject only into top frame unless necessary #159

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
For example, with Google Reader, flash content is loaded with iframes. All 
active rules are applied to this iframe, which sometimes screws things up.

Original issue reported on code.google.com by fletc...@tomalty.com on 29 Dec 2011 at 3:33

GoogleCodeExporter commented 8 years ago
Please include a screenshot of what you mean, be specific. Your claimed cause 
it incorrect as it is not technically possible. By design, CSS and JS in parent 
windows cannot affect content in iframes. JS can do so in some specific cases 
but only if both windows are on the same domain and only if there are scripts 
on both sides specifically designed to interact. (It's not possible unless they 
are iframes with other Google Readers open in them...).

Note that sometimes iframes, usually flash videos, will create persistent white 
boxes. This is not a Minimalist issue.

These details are important. Please fill them out:

Minimalist version   -
Relevant core module -
Chrome version       -
Operating System     -
Language             -
Google Apps user?    -
Other extensions     -

Please provide any additional information below and attach screenshots if
relevant.

Original comment by anst...@gmail.com on 29 Dec 2011 at 4:26

GoogleCodeExporter commented 8 years ago
Sorry I wasn't clear. I mean that the JavaScript and CSS are actually loaded in 
frames themselves, the same way that they are loaded in the main page. I looked 
via the inspector.

To reproduce, open Google Reader and find an item with an embed in it. Find it 
in the elements inspector, and then look at the CSS and JavaScript there. Even 
though the frame URL doesn't match the Google Reader pattern, it's still loaded 
in there.

Original comment by fletc...@tomalty.com on 29 Dec 2011 at 4:32

GoogleCodeExporter commented 8 years ago
Oh I see. Gmail is made of a ton of iframes so stuff had to be injected into 
all of them. I'll see if there is a way to prevent this is Reader.

Original comment by anst...@gmail.com on 29 Dec 2011 at 4:35