haroldo-ok / choice4genesis

A ChoiceScript clone that generates SGDK-compatible C source for the Sega Genesis
https://haroldo-ok.itch.io/choice4genesis
MIT License
20 stars 2 forks source link

Fix handling of filenames with special chars. #110

Closed haroldo-ok closed 1 year ago

haroldo-ok commented 1 year ago
          aha! I *think* i found out whats happening thanks to your info. i tested 2 folders, one of them worked the other didnt. The one that didnt work had file name begin with a #. like 1chr1v1  ... and the error makes more sense now res/gfx.rs:6: Error: junk at end of line, first unrecognized character is `1'..  its saying 1 (But at the end not beginning?) anyhow I changed the name to "hmm,jpg" and it worked! Sooo, is there an update that can understand filenames beginning with #s (so i dont have to change many file names/code?) thanks!

Originally posted by @zartan9 in https://github.com/haroldo-ok/choice4genesis/issues/66#issuecomment-1534739216

This is related to #87, that should have been fixed, but apparently wasn't.

haroldo-ok commented 1 year ago

Found a similar bug, where both 1chr1v1.png and #1chr1v1.png produce the same variable name, causing compilation errors.

haroldo-ok commented 1 year ago

By updating the version to 0.14.2, the problem is solved: https://github.com/haroldo-ok/choice4genesis/issues/66#issuecomment-1737265415