harp-tech / protocol

Description of the Harp protocol.
https://harp-tech.org/protocol/BinaryProtocol-8bit.html
MIT License
3 stars 5 forks source link

Consider defining the DTR pin state as part of the protocol standard #14

Open bruno-f-cruz opened 6 months ago

bruno-f-cruz commented 6 months ago

Related to https://github.com/bonsai-rx/harp/pull/81

artursilva0 commented 6 months ago

Since this is a serial communication specific pin, shouldn't this pin state be specified in the core implementation instead?

In my opinion the Harp protocol (which is just one part of the Harp Standard) should be as much agnostic as possible to the communication protocols.

bruno-f-cruz commented 6 months ago

This spec doesn't need to necessarily go into the protocol, I would probably but it in the Device. The same way that the baudrate of the synchronization protocol is not defined in its own document.

glopesdev commented 6 months ago

Feedback from SRM meeting:

bruno-f-cruz commented 4 months ago

This has been added to the new Bonsai version. I will make the draft into a PR to be reviewed.