Closed GarthDB closed 9 years ago
Thanks @GarthDB! If you want to open a PR here, that will probably get turned into the parent library. If not, that’s cool too, I can port it.
@kennethormandy I can do that - do you need me to do that before this pull request can be accepted?
I can break this into another pull request if you'd prefer, but the site's pagespeed score is pretty low. Every little bit of performance counts, especially for a project like this.
I've started by optimizing the svgs and a couple of the pngs. To be honest, I think most (if not all) of the pngs would be smaller as svgs as well. I could recreate them, but if anyone has the original vector files it would be faster to use the source.
After the images it would be good to consider using CloudFlare's free optimizations to minimize and gzip the content.
Thanks for this! Sorry I took so long to merge it.
I do have the original .png
s as .svg
s, but I believe I checked them and their complexity meant inlining them wasn’t actually as efficient as making them .png
s. But maybe keeping them in image tags and referencing them would still be better.
The site is published on Surge.sh which we make, everything else is minified and gzipped automatically, but we aren’t doing that with SVG the image sometimes. We also use an ETag-based to caching headers that Google’s Page Speed doesn’t really take into consideration, so that might be the cause of some of the lower numbers. We have an 84% on Pingdom which seems alright, and good results for everything that is in our control on WebPagetest (ex. we can’t cache Google Analytics, Twitter widgets, etc. of course).
I really appreciate that you took the time to take a look at that and make the SVG improvements however, and am totally open to more suggestions if you have ‘em. Thanks @GarthDB!
Jade has a new logo; here's an update.