harperreed / image-dupes

A tool for scanning directories, identifying duplicate or similar images via hashing, and generating an HTML report for easy review.
1 stars 0 forks source link

Resolve CI/CD failures for PR #28 #30

Open sweep-ai[bot] opened 7 hours ago

sweep-ai[bot] commented 7 hours ago

Purpose

Review the CI/CD pipeline results for PR #28, identify the failing steps, and make necessary corrections to ensure all checks pass.

Description

The changes in this pull request address the following:

  1. Updated the Go version in the lint job of the GitHub Actions workflow to match the version used in the test and race_test jobs (1.21).
  2. Improved the hash.go file to make the computeHashes function concurrent, using goroutines to process images in parallel and avoid race conditions.
  3. Added a new test function TestConcurrentFileHashing in hash_test.go to check for potential race conditions when hashing files concurrently.
  4. Ensured that all existing tests in hash_test.go are properly implemented and cover various scenarios.

Summary

The key changes in this pull request include:

Fixes

29. Continue the conversation here: https://app.sweep.dev/c/eeba4848-1464-4de9-a0d0-c087913f8aaa.

To have Sweep make further changes, please add a comment to this PR starting with "Sweep:".

:book: For more information on how to use Sweep, please read our documentation.

Tracking ID: 59dcfe9e49
sweep-ai[bot] commented 7 hours ago

❌ Error while fixing CI

Traceback (most recent call last):
  File "/app/sweepai/handlers/fix_ci.py", line 286, in fix_ci_failures_once
    logs_list = get_ci_failure_logs(error_runs, pull_request)
  File "/app/sweepai/handlers/fix_ci.py", line 182, in get_ci_failure_logs
    raw_logs = unzip_and_extract_logs(raw_binary_logs)
  File "/app/sweepai/handlers/fix_ci.py", line 137, in unzip_and_extract_logs
    zip_file = zipfile.ZipFile(io.BytesIO(blob))
  File "/usr/local/lib/python3.10/zipfile.py", line 1272, in __init__
    self._RealGetContents()
  File "/usr/local/lib/python3.10/zipfile.py", line 1339, in _RealGetContents
    raise BadZipFile("File is not a zip file")
zipfile.BadZipFile: File is not a zip file

File is not a zip file

Sweep has encountered a runtime error unrelated to your request. Please let us know via this link or at support@sweep.dev directly.

:book: For more information on how to use Sweep, please read our documentation.

Tracking ID: 59dcfe9e49-ci-0