search

harphub / harpIO

IO functions for HARP
https://harphub.github.io/harpIO/
Other
6 stars 16 forks source link

Obsoul format read update #109

Closed meteorolog90 closed 5 months ago

meteorolog90 commented 6 months ago

Update contains:

andrew-MET commented 5 months ago

@meteorolog90 I'd like to remove the dependency on the stringr package, so could you replace str_sub with the base functionsubstring or substr, and str_replace_all with gsub. I'm not sure if these will work as direct replacements, but they ultimately have the same functionality.

meteorolog90 commented 5 months ago

@andrew-MET

@meteorolog90 I'd like to remove the dependency on the stringr package, so could you replace str_sub with the base functionsubstring or substr, and str_replace_all with gsub. I'm not sure if these will work as direct replacements, but they ultimately have the same functionality.

OK, I'll do that. Thanks for your feedback.

meteorolog90 commented 5 months ago

@andrew-MET I did this replacements : str_sub replaced with substr, str_replace_all with gsub. This changes tested and they worked.