harphub / harpIO

IO functions for HARP
https://harphub.github.io/harpIO/
Other
6 stars 16 forks source link

read_eps_interpolate() doesn't work with tidyr version 1.0.0 #3

Closed mpartio closed 4 years ago

mpartio commented 4 years ago

read_eps_interpolate() does not work with tidyr version 1.0.0.

Reading: /tmp/HARP_vfld7R4n/MEPS_prod/vfldMEPS_prodmbr009201908010054
Joining data.
Preparing data to write.
Error: Column `file_name` must be length 1 (the group size), not 741
In addition: Warning messages:
1: In get("station_list") :
  input string 'Végeirsstadir-i-Fnjoskadal' cannot be translated to UTF-8, is it valid in 'ANSI_X3.4-1968'?
2: `cols` is now required.
Please use `cols = c(sub_model, member, members_out, lag)` 
3: `cols` is now required.
Please use `cols = c(fcdate)` 
4: `cols` is now required.
Please use `cols = c(LDT)` 
5: `cols` is now required.
Please use `cols = c(MBR)` 
6: The `.drop` argument of `unnest()` is deprecated as of tidyr 1.0.0.
All list-columns are now preserved.
This warning is displayed once per session.
Call `lifecycle::last_warnings()` to see where this warning was generated. 
7: `cols` is now required.
Please use `cols = c(file_names)` 
8: `cols` is now required.
Please use `cols = c(member, members_out, lag)` 
9: `.key` is deprecated 
Execution halted

With patch

diff --git a/R/read_eps_interpolate.R b/R/read_eps_interpolate.R
index 22ba408..6b12bba 100644
--- a/R/read_eps_interpolate.R
+++ b/R/read_eps_interpolate.R
@@ -530,7 +530,7 @@ read_eps_interpolate <- function(
           LDT3      = formatC(lead_time, width = 3, flag = "0")
         )

-      sqlite_data <- sqlite_data %>%
+      sqlite_data <- sqlite_data %>% tibble::as.tibble() %>%
         dplyr::mutate(
           file_name = as.vector(glue::glue_data(sqlite_data, get_template(sqlite_template)))
         ) %>%

it works.

andrew-MET commented 4 years ago

fixed here: https://github.com/andrew-MET/harpIO/commit/8b3ee2b1704112ded673791ba4872160191fa14a