harrison314 / SlovakEidSignTool

Example of signing documents using Slovak eID (PAdES, CAdES)
GNU Affero General Public License v3.0
6 stars 3 forks source link

Compatibility fixes #6

Closed JaskaRoman closed 1 year ago

JaskaRoman commented 1 year ago

Compatibility fixes for issues caused by new IDs and eID Klient versions.

harrison314 commented 1 year ago

@JaskaRoman Why was the use of CKA_LABEL removed from key identification?

JaskaRoman commented 1 year ago

@harrison314 The change was based on my observations of the actual values stored on a newer slovak ID. My theory is, that the original match of the label between the key and the certificate was erroneous and fixed in subsequent revisions. Your original code relied on this behavior. It's my understanding, that the CKA_LABEL check was not crucial, as the surrounding code checks the actual ID. The current CKA_LABEL values are 'Signing key' for the key and 'Signing certificate' for the certificate.

harrison314 commented 1 year ago

OK, thanks.